Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PageFlip App - allow custom .json file? #101

Open
ComedyTomedy opened this issue Jun 24, 2020 · 8 comments
Open

PageFlip App - allow custom .json file? #101

ComedyTomedy opened this issue Jun 24, 2020 · 8 comments

Comments

@ComedyTomedy
Copy link
Contributor

It'd be nice to be able to have (local on android filesystem, or remote on a server) a personal custom JSON file for adding additional comics. The format would be the same as supported_sites.json, and ideally the user-json file should overshadow the builtin one (to allow the 2nd use case below).

Use case: I find a new comic that isn't on the app, and can start reading it without needing the lengthy process of @oseparovic updating PageFlip
Use Case 2: updating broken selectors in existing comics, in case a website update makes a comic temporarily unusable.

In both cases, users should be encouraged to also report issues here on github.

@oseparovic
Copy link
Owner

This is a good suggestion and something I might add support for in future

@ComedyTomedy
Copy link
Contributor Author

Another thought - NSFW comics could be moved into an external file, that could then be added by users from this repo ☺

If we wanted to get really fancy, allow adding JSON files by URL, so they automatically update.

@ComedyTomedy
Copy link
Contributor Author

@oseparovic Any further thoughts on this? Or are there other possible ways around the NFSW ban? I find I use PageFlip less than I would otherwise, it's be nice to have all (or nearly all) the comics I wanna read in a single place.

(oh and NP on the PRs - it's fun and educational ☺ there's no rush to commit them)

@oseparovic
Copy link
Owner

I'd like to keep all the .json here if at all possible. A separate file is still more of a backup plan. I have concerns that a separate file will lead to a lot of emails about CSS and reviewing people's code.

I have opened another ticket with google support asking about clarification on sexual content and whether an age gate would be an acceptable solution.

In the meantime you can turn on dev mode in the app by going to about and tapping the version number 7 times which will enable NSFW comics.

@ComedyTomedy
Copy link
Contributor Author

Well that fixes my problem ♥ thanks for everything! Close this issue if you wish, or leave it as a reminder.

@tyalie
Copy link

tyalie commented Apr 3, 2021

I think such a feature would be nice in many ways. I'd like to add an NSFW comic strip, without needing to wait for an app update or until my pull request is being accepted

@SmilingTexan
Copy link

a custom page would be nice, maybe limit it to the dev mode?

@wsu808
Copy link

wsu808 commented Jan 25, 2024

Any update on the topic?
Adding local json support would simply let us fully test it before sharing and start reading right away.

Then there can be an action on long press that apart from "remove" also have option "share with community" so it is send for verification.

Btw. Are non-english comics supported or there is no point in requesting them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants