Generate rook storage nodes from ceph-resource nodes and add flexibility to Helm values overall
#1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…more flexible configuration. make rook_storage optional and dynamically generate nodes based on ceph-resource group make it backwards compatible with rook_storage_nodes which is still used in testbed Signed-off-by: Oriano de-Stefani <[email protected]>
Lappihuan
changed the title
ceph-resource nodes and add flexibility to Helm values overallceph-resource nodes and add flexibility to Helm values overall
added 3 commits
September 19, 2024 19:29
Signed-off-by: Oriano de-Stefani <[email protected]>
Signed-off-by: Oriano de-Stefani <[email protected]>
Signed-off-by: Oriano de-Stefani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update proposes dynamically generating storage nodes from the
ceph-resourcegroup, makingrook_storageoptional and deprecating the redundantrook_storage_nodes. This change simplifies configuration while maintaining flexibility and improves the process of node creation.The PR also introduces overrides for
rook_monandrook_mgrin the Helm values, enabling more customizable setups. For example,rook_moncan be used to configure a stretch cluster, as described in the Rook documentation here, providing more flexibility for specific deployment scenarios.