Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve DX if ok creates a packages.yml #356

Open
haavardeide opened this issue Jan 7, 2025 · 1 comment
Open

Improve DX if ok creates a packages.yml #356

haavardeide opened this issue Jan 7, 2025 · 1 comment

Comments

@haavardeide
Copy link
Contributor

Context, see: https://oslokommune.slack.com/archives/CV9EGL9UG/p1736235504130289

When running ok pkg add ... and there is no packages.yml we generate one for the user, but: we should give a notice that we have done so, and add information that you must add DefaultPackagePathPrefix: boilerplate/github-actions to the file if you are installing github action boilerplates.

Other things considered:

  • detect that we are inside a .github/workflows directory, but I don't think we should do that type of magic (yet)
  • add a flag to the command: ok pkg add ... --type github-actions but that would require the user to know this flag on initial creation

But for now, since we are not doing this command very often, we should just give a good notice and see if that will nudge the user in the right direction.

@Kielo87
Copy link

Kielo87 commented Jan 13, 2025

Bedre feilmelding, få tak i Mira når du jobber med det

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants