Added Researcher Toolbar #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackMcPhillips1543
requested changes
Feb 3, 2025
| toolsContainer: { | ||
| display: 'flex', | ||
| flexDirection: 'row', | ||
| alignItems: 'center', |
There was a problem hiding this comment.
Can you please move all of the CSS to a separate file so that it aligns with the other files
git-voo
requested changes
Feb 4, 2025
There was a problem hiding this comment.
Building out the ResearcherToolbar as a separate component was a great idea. it makes it easier to add other tools as the requirements evolve.
Here are some quick suggestions to get this through.
- move this component into a components directory such that the path reads
/frontend/src/components/ResearcherToolbar.js - Move the style into a separate style file to follow the styling convention of other components
- Add an action button - for instance, "Submit" - at the end such that after entering values in the provided fields the button can be used to submit those values
- It'd be great to have the toolbar stay side by side with the stance time view so that the toolbar grows vertically as more tools come in.
Something like...
This might be a stretch for the scope of this PR so if time does not allow, we can move it into a new issue for next time.
Well done!
git-voo
reviewed
Feb 4, 2025
| @@ -0,0 +1,79 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
This line is not necessary, React is imported globally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53
What was changed:
Implemented the researcher toolbar component that allows the researcher to modify the moving average factor and threshold.
The toolbar is designed with flexibility to accommodate additional tools in the future.
Why was it changed:
This change was required to provide the researcher interface with necessary tools for modifying parameters like the moving average factor and threshold, without interrupting data streaming. This improves user interaction and control over the system.
How was it changed:
Created a new ResearcherToolbar component that includes input fields for adjusting the moving average factor and threshold.
The toolbar was styled to be compact, horizontally aligned, and visually consistent with the rest of the interface.
The component was integrated into the main app, allowing for live updates of the moving average and threshold values as they are adjusted.