Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme11 Custom Blocks are missing #42

Open
carakey opened this issue Aug 25, 2023 · 2 comments
Open

Theme11 Custom Blocks are missing #42

carakey opened this issue Aug 25, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@carakey
Copy link
Contributor

carakey commented Aug 25, 2023

According to the theme documentation, several of the theme components are controlled as "Custom Blocks" and managed from the dashboard:

  • Right Sidebar Slider
  • Twitter Block
  • News Slider
  • Current Issue Block
  • Author Info Block

On the demo journal on OJS-Test, these components are either not appearing at all on the public view, or are appearing as broken, and the blocks indicated in the guide are not present in the Custom Blocks plugin.

Related work: #19

@carakey carakey added the bug Something isn't working label Aug 25, 2023
@carakey
Copy link
Contributor Author

carakey commented Aug 25, 2023

Additional testing on OJS-Test. Forest Phyt. journal did not have any custom blocks created already. I disabled the Custom Block plugin for the FP journal, then set the FP journal's theme to be Theme 11 and saved. The custom block manager was not automatically enabled by setting the theme. I re-enabled the Custom Block plugin, but Theme 11 blocks did not appear. I'm not sure what else I can do on my end.

@wickr
Copy link
Member

wickr commented Aug 26, 2023

So far, have found that the 'Recent News' slider was set to not display (in 2 different places). That's at least appearing now, but it's unclear how to change the content so it's actually useful.

The Current Issue custom block had a bad conditional check in the code, so now it's at least displaying a message.

There doesn't appear to be any way for a theme to create Custom Blocks directly, so the theme documentation saying to use specific Custom Blocks implies that they were set up manually already.

Along those lines, I created 2 custom blocks that matched the IDs that it looked like the code expects, but the theme still doesn't seem to be pulling in the Custom Block text. It's unclear if this actually works or if the values need to be set directly in the theme file (usually the footer.tpl file).

@carakey carakey moved this from Todo to Blocked in OJS 3 Migration and Enhancement Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Blocked
Development

No branches or pull requests

2 participants