Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Built-in support for saving/loading optimizer state in safetensors format #187

Closed
minghuaw opened this issue Jan 27, 2025 · 0 comments · Fixed by #190
Closed

Built-in support for saving/loading optimizer state in safetensors format #187

minghuaw opened this issue Jan 27, 2025 · 0 comments · Fixed by #190

Comments

@minghuaw
Copy link
Collaborator

minghuaw commented Jan 27, 2025 •
edited
Loading

This would probably require changing the optimizer trait to include a function that returns an iterator (or something equivalent) of (K, &Array) where K: AsRef<str>
@minghuaw minghuaw linked a pull request Jan 29, 2025 that will close this issue
fix & example: mistral #178
Merged
@minghuaw minghuaw removed a link to a pull request Jan 30, 2025
fix & example: mistral #178
Merged
@minghuaw minghuaw mentioned this issue Jan 30, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: save/load optimizer state oxideai/mlx-rs
1 participant
@minghuaw