Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading logging: Blob document exists in database but not on file system #575

Open
sandreae opened this issue Oct 5, 2023 · 4 comments

Comments

@sandreae
Copy link
Member

sandreae commented Oct 5, 2023

How to reproduce: publish an sighting with an image using https://github.com/p2panda/meli/tree/publish-blob

I/aquadoggo::materializ..(31695): Creating blob at path /data/user/0/com.p2panda.meli/files/0020e9e26e248795e9812c6cbc845ebfc684e51b461d5ca6db307478ee20e9ba805d
I/aquadoggo::materializ..(31695): Creating blob at path /data/user/0/com.p2panda.meli/files/00205f8edadea98824587129216785f9fa9b43548d63f8169cf2037836f4f650648d
I/aquadoggo::materializ..(31695): Creating blob at path /data/user/0/com.p2panda.meli/files/0020b1fce8916c1a9b5b9c197b39e32705fc4950d5c8c45727c7f82fd782865e5dfa
I/aquadoggo::materializ..(31695): Creating blob at path /data/user/0/com.p2panda.meli/files/00205f8edadea98824587129216785f9fa9b43548d63f8169cf2037836f4f650648d
I/aquadoggo::materializ..(31695): Creating blob at path /data/user/0/com.p2panda.meli/files/0020b1fce8916c1a9b5b9c197b39e32705fc4950d5c8c45727c7f82fd782865e5dfa
I/aquadoggo::materializ..(31695): Creating blob at path /data/user/0/com.p2panda.meli/files/0020e9e26e248795e9812c6cbc845ebfc684e51b461d5ca6db307478ee20e9ba805d
I/aquadoggo::materializ..(31695): Creating blob at path /data/user/0/com.p2panda.meli/files/00205f8edadea98824587129216785f9fa9b43548d63f8169cf2037836f4f650648d
W/aquadoggo::http::api(31695): Data inconsistency detected: Blob document 4a21e1 exists in database but not on file
W/aquadoggo::http::api(31695):                 system at path /data/user/0/com.p2panda.meli/files/00208084e70d7b975650be74a07c8e9173eec6194b75a7626fc4269ec266614a21e1!
I/aquadoggo::materializ..(31695): Creating blob at path /data/user/0/com.p2panda.meli/files/0020b1fce8916c1a9b5b9c197b39e32705fc4950d5c8c45727c7f82fd782865e5dfa
...
W/aquadoggo::http::api(31695): Data inconsistency detected: Blob document 4a21e1 exists in database but not on file
W/aquadoggo::http::api(31695):                 system at path /data/user/0/com.p2panda.meli/files/00208084e70d7b975650be74a07c8e9173eec6194b75a7626fc4269ec266614a21e1!
I/aquadoggo::materializ..(31695): Creating blob at path /data/user/0/com.p2panda.meli/files/00208084e70d7b975650be74a07c8e9173eec6194b75a7626fc4269ec266614a21e1
I/aquadoggo::materializ..(31695): Creating blob at path /data/user/0/com.p2panda.meli/files/0020e9e26e248795e9812c6cbc845ebfc684e51b461d5ca6db307478ee20e9ba805d
@sandreae sandreae added the bug Something isn't working label Oct 5, 2023
@sandreae
Copy link
Member Author

sandreae commented Oct 5, 2023

It seems that requesting the blob after it has been inserted into the blob store but before it's been materialised onto the file system causes this error.

@adzialocha
Copy link
Member

adzialocha commented Oct 7, 2023

Ah ja, that was indented as an integrity error (I've wiped my blobs folder or misconfigured my node) but I can see now that there's a valid case for requesting the file too early .. we could still leave it? Or does it look too scary?

@sandreae
Copy link
Member Author

sandreae commented Oct 7, 2023

Yeh, it's good info to have if you're debugging, but a bit scary if everything is actually fine. Maybe just pushing it down to debug is good.

@adzialocha
Copy link
Member

Yeh, it's good info to have if you're debugging, but a bit scary if everything is actually fine. Maybe just pushing it down to debug is good.

Cool, we're warning already for the misconfiguration case.

@adzialocha adzialocha removed the bug Something isn't working label Oct 12, 2023
@adzialocha adzialocha changed the title Blob document exists in database but not on file Misleading logging: Blob document exists in database but not on file system Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants