Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Localization System in pactus-gui to Match pactus-gui-widgetbook #57

Closed
esmaeil-ahmadipour opened this issue Jan 10, 2025 · 0 comments · Fixed by #60
Closed
Assignees
Labels
enhancement New feature or request feature Add/Create new feature

Comments

@esmaeil-ahmadipour
Copy link
Collaborator

Overview

The pactus-gui localization system relies on Easy Localization , which has buggy behavior when changing languages. We need to replace it with the l10n package to align with pactus-gui-widgetbook for consistency, better maintainability, and a centralized translation key structure.

Goals

  • Replace Easy Localization with l10n.
  • Centralize and standardize translation keys.
  • Align with pactus-gui-widgetbook.

Proposed Changes

  1. Replace Easy Localization with l10n, removing outdated dependencies and configurations.
  2. Centralize translation keys in one file with a consistent naming convention.
  3. Refactor translation logic to align with the new system and update all relevant code.
  4. Ensure compatibility with pactus-gui-widgetbook.
  5. Update tests to validate the new system and ensure that the CI pipeline includes checks for correct translation automation, ensuring no missing translations.

Impact

  • Existing code dependent on Easy Localization will need updates.
@esmaeil-ahmadipour esmaeil-ahmadipour added enhancement New feature or request feature Add/Create new feature labels Jan 10, 2025
@esmaeil-ahmadipour esmaeil-ahmadipour self-assigned this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature Add/Create new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant