Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consensus query-proposal message won't get a response #1452

Closed
b00f opened this issue Aug 3, 2024 · 0 comments · Fixed by #1502
Closed

Consensus query-proposal message won't get a response #1452

b00f opened this issue Aug 3, 2024 · 0 comments · Fixed by #1502
Assignees
Milestone

Comments

@b00f
Copy link
Collaborator

b00f commented Aug 3, 2024

Description

Even though we have addressed the missed proposal in issue #1438, there is a situation where the query-proposal may still get no response.
The scenario is as follows in time order:

  1. Validator B is the proposer and becomes faulty after proposing the block.
  2. Validator P decides on No in Change-Propose phase without having the proposal and queries the proposer from Validators X and Y. However, neither X nor Y has decided yet.
  3. Validators X and Y then decide, but Validator P still has no proposal and cannot publish the PREPARE vote.

This happened here: GitHub Actions Run.

How to Reproduce

Using the random seed in the above test, you can reproduce the failed test again.

Workaround

This situation is very unlikely to happen in the mainnet, and even if it does, once the validator restarts its node, the proposal will be queried again, and the system will return to normal.

@b00f b00f changed the title Consenssu quey-proposl message won't get response Consensus query-proposal message won't get a response Aug 3, 2024
@b00f b00f added this to the v1.4.1 milestone Aug 3, 2024
@b00f b00f added the Consensus label Aug 3, 2024
@b00f b00f self-assigned this Aug 3, 2024
@b00f b00f modified the milestones: v1.4.1, v.1.5.0 Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant