Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detecting Bootstraper node #756

Closed
themantre opened this issue Oct 19, 2023 · 3 comments · Fixed by #759 or #760
Closed

Detecting Bootstraper node #756

themantre opened this issue Oct 19, 2023 · 3 comments · Fixed by #759 or #760
Labels
good first issue Good for newcomers help wanted Extra attention is needed network

Comments

@themantre
Copy link
Contributor

themantre commented Oct 19, 2023

It is necessary to detect if a node is a bootstrap node.
One way is by adding a boolean value to the config file.
Another way is to read all bootstrap peers in the config, and if the node's peer ID is the same as one of the bootstrap nodes, it can be marked as a bootstrap node. In this case, we keep the config intact.

After detecting the bootstrap node, we can mark it as a NodeServer. You can find an example of this implementation here.

Note: We can also prevent the "Dial to self" error message.

@themantre themantre added good first issue Good for newcomers help wanted Extra attention is needed network labels Oct 19, 2023
@themantre
Copy link
Contributor Author

/bounty $25

@algora-pbc
Copy link

algora-pbc bot commented Oct 19, 2023

💎 $25 bounty created by themantre
🙋 If you start working on this, comment /attempt #756 to notify everyone
👉 To claim this bounty, submit a pull request that includes the text /claim #756 somewhere in its body
📝 Before proceeding, please make sure you can receive payouts in your country
💵 Payment arrives in your account 2-5 days after the bounty is rewarded
💯 You keep 100% of the bounty award
🙏 Thank you for contributing to pactus-project/pactus!

Attempt Started (GMT+0) Solution
🟢 @melsonic Oct 20, 2023, 5:38:16 AM WIP

@melsonic
Copy link

melsonic commented Oct 20, 2023

/attempt #756

Options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed network
Projects
None yet
2 participants