Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new deck to capture missed trivia cards #13

Open
papistan opened this issue Sep 28, 2017 · 5 comments
Open

Add new deck to capture missed trivia cards #13

papistan opened this issue Sep 28, 2017 · 5 comments

Comments

@papistan
Copy link
Owner

Would like to create a deck of cards user has marked 'missed' with red button. As user goes through cards, missed ones are thrown into this deck all together. They can then review at any time.

Not sure where the deck would sit on the page, but thinking at top of deck list.

@jaimellamasi
Copy link

I'll take this :)

@papistan
Copy link
Owner Author

@jllamasi great! Reading my comment above maybe I'm not so clear, but I'm thinking an empty "review" deck that gets filled with the cards user does not get correct. If that doesn't make sense let me know. Thanks!

@papistan
Copy link
Owner Author

papistan commented Oct 3, 2017

hi @jllamasi any progress so far?

@jaimellamasi
Copy link

jaimellamasi commented Oct 3, 2017

Hi @papistan. I'm new with React-Redux and I took this task to get familiar with this technology, I was this weekend trying to figure out how everything's working underneath.

While discovering the code, I took the liberty to improve something:

  1. There's a new property 'selected' in the deck list component in order to stand it out via CSS .
  2. Once you're done with the cards of a deck, there's no possibility to keep clicking on buttons in order to avoid increasing the total score.

Having this, I can do two pull requests to get the above features merged, if you want to.

And now, we can start discussing how we implement missed cards. What I thought about this feature is:

  • Create a new deck named 'Missed decks' on the deck list with following requirements:
  • This deck is initially empty.
  • Any missed card will automatically be inserted on this deck.
  • Cards from this deck are removed once you click on green button.
  • Missed cards from this deck does not trigger any action, just move on the next card.

What do you think?

Regards,

@papistan
Copy link
Owner Author

papistan commented Oct 3, 2017

@jllamasi awesome! Thanks for your quick response. I like the idea of a selected deck. I also think a fix to the score issue would be great. Feel free to send the PR and I'll take a look later today and merge.

For the missed cards deck, that functionally sounds perfect. I think eventually we could have some sort of animation to show a card is added to missed deck.
Thanks again and feel free to message me if you have questions about underlying issues in the react portions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants