-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new deck to capture missed trivia cards #13
Comments
I'll take this :) |
@jllamasi great! Reading my comment above maybe I'm not so clear, but I'm thinking an empty "review" deck that gets filled with the cards user does not get correct. If that doesn't make sense let me know. Thanks! |
hi @jllamasi any progress so far? |
Hi @papistan. I'm new with React-Redux and I took this task to get familiar with this technology, I was this weekend trying to figure out how everything's working underneath. While discovering the code, I took the liberty to improve something:
Having this, I can do two pull requests to get the above features merged, if you want to. And now, we can start discussing how we implement missed cards. What I thought about this feature is:
What do you think? Regards, |
@jllamasi awesome! Thanks for your quick response. I like the idea of a selected deck. I also think a fix to the score issue would be great. Feel free to send the PR and I'll take a look later today and merge. For the missed cards deck, that functionally sounds perfect. I think eventually we could have some sort of animation to show a card is added to missed deck. |
Would like to create a deck of cards user has marked 'missed' with red button. As user goes through cards, missed ones are thrown into this deck all together. They can then review at any time.
Not sure where the deck would sit on the page, but thinking at top of deck list.
The text was updated successfully, but these errors were encountered: