Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time_bucket function calculates buckets for all rows even when LIMIT is applied #86

Closed
2 tasks done
vaibhawvipul opened this issue Aug 19, 2024 · 1 comment
Closed
2 tasks done
Labels
bug Something isn't working good first issue Good for newcomers priority-low Low priority issue

Comments

@vaibhawvipul
Copy link
Contributor

What happens?

#32 closed #52.

However, when applying a limit to a query with time_bucket, the bucket is still calculated for all rows in the table

e.g. select time_bucket('5m', trips.tpep_pickup_datetime) from trips limit 10; touches all rows not just the first 10

using a subquery seems to work fine as a workaround select time_bucket('5m', t.tpep_pickup_datetime) from (select * from trips limit 10) t; but we want limit to work properly and get pushed down to duckdb

To Reproduce

More info here - #32 (comment)

OS:

all versions

ParadeDB Version:

latest

Are you using ParadeDB Docker, Helm, or the extension(s) standalone?

ParadeDB Docker Image

Full Name:

Vipul Vaibhaw

Affiliation:

ParadeDB

Did you include all relevant data sets for reproducing the issue?

Yes

Did you include the code required to reproduce the issue?

  • Yes, I have

Did you include all relevant configurations (e.g., CPU architecture, PostgreSQL version, Linux distribution) to reproduce the issue?

  • Yes, I have
@vaibhawvipul vaibhawvipul added bug Something isn't working good first issue Good for newcomers priority-medium Medium priority issue labels Aug 19, 2024
@philippemnoel philippemnoel added priority-low Low priority issue and removed priority-medium Medium priority issue labels Oct 20, 2024
@philippemnoel
Copy link
Collaborator

Removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers priority-low Low priority issue
Projects
None yet
Development

No branches or pull requests

2 participants