Integrate EngineArgs into NodeCommand

[mattsse]

Describe the feature

we've deprecated the legacy launcher and can now integrate the EngineArgs into the default NodeCommand

reth/bin/reth/src/main.rs

Lines 77 to 80 in 28d5231

	let engine_tree_config = TreeConfig::default()
	.with_persistence_threshold(engine_args.persistence_threshold)
	.with_memory_block_buffer_target(engine_args.memory_block_buffer_target)
	.with_state_root_task(engine_args.state_root_task_enabled);

reth/crates/cli/commands/src/node.rs

Line 23 in 28d5231

pub struct NodeCommand<

so that we no longer have to do any of this:

reth/bin/reth/src/main.rs

Lines 70 to 75 in 28d5231

	if engine_args.experimental {
	warn!(target: "reth::cli", "Experimental engine is default now, and the --engine.experimental flag is deprecated. To enable the legacy functionality, use --engine.legacy.");
	}
	let use_legacy_engine = engine_args.legacy;
	match use_legacy_engine {

TODO

• move EngineArgs into NodeCommand
• remove deprecated EngineArgs fields: experimental + legacy
• update/simplify main function to just these lines:

  reth/bin/reth/src/main.rs

  Lines 98 to 99 in 28d5231

  	let handle = builder.launch_node(EthereumNode::default()).await?;
  	handle.node_exit_future.await

• use treeconfig in the launcher by replacing Default
  

  reth/crates/node/builder/src/builder/mod.rs

  Line 567 in 28d5231

  EngineNodeLauncher::new(task_executor, builder.config.datadir(), Default::default());

  
  with:
  

  reth/bin/reth/src/main.rs

  Lines 77 to 80 in 28d5231

  	let engine_tree_config = TreeConfig::default()
  	.with_persistence_threshold(engine_args.persistence_threshold)
  	.with_memory_block_buffer_target(engine_args.memory_block_buffer_target)
  	.with_state_root_task(engine_args.state_root_task_enabled);

  obtained from NodeConfig (after moving EngineArgs into NodeCommand)

Additional context

No response

[htiennv]

Hi @mattsse , Can you assign me to this task? Thanks

[mymiracle0118]

Mind if I take this issue?

[programskillforverification]

Could you assign this one to me?