Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cssmodules-pure-no-check feature #889

Open
jantimon opened this issue Jan 8, 2025 · 1 comment
Open

cssmodules-pure-no-check feature #889

jantimon opened this issue Jan 8, 2025 · 1 comment

Comments

@jantimon
Copy link

jantimon commented Jan 8, 2025

hi @devongovett

would you be open to port the cssmodules-pure-no-check feature from postcss to lightningcss?

The feature is a limited opt-out for the cssModules: { pure: true } linting rule similar to @ts-ignore or @ts-nocheck or eslint-disable for edge cases in large projects where lightningcss is configured globally

For example:

/** cssmodules-pure-no-check */

:global(#stripe-modal-backdrop) {
  background: rgba(0, 0, 0, 0.5);
}

In postcss the /** cssmodules-pure-no-check */ disables the linting rule for the entire file.

If you are okay with porting the feature I would love to start working on a PR

@jantimon
Copy link
Author

jantimon commented Jan 23, 2025

I went ahead and implemented this in the PR #898 to give you a better idea

Its just a minimal change but would be really helpful for projects transitioning to pure CSS modules

Please take a look when you have a chance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant