Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AWSWorker optional #520

Open
rth opened this issue May 8, 2021 · 1 comment
Open

Make AWSWorker optional #520

rth opened this issue May 8, 2021 · 1 comment

Comments

@rth
Copy link
Collaborator

rth commented May 8, 2021

Currently when pip installing ramp-board there is an import of botocore and boto3 (which is not included in the dependencies), that produces,

  File "/home/ramp/ramp-board/ramp-engine/ramp_engine/__init__.py", line 1, in <module>
    from .aws import AWSWorker
  File "/home/ramp/ramp-board/ramp-engine/ramp_engine/aws/__init__.py", line 1, in <module>
    from .worker import AWSWorker  # noqa
  File "/home/ramp/ramp-board/ramp-engine/ramp_engine/aws/worker.py", line 5, in <module>
    from . import api as aws
  File "/home/ramp/ramp-board/ramp-engine/ramp_engine/aws/api.py", line 11, in <module>
    import botocore  # noqa
ModuleNotFoundError: No module named 'botocore'

I think ideally we should make it possible to install ramp-board without using the AWS worker and install the corresponding dependencies particularly that AWS has a tendency to pin all requirements which for a library is not ideal nevermind they seem to have improved that situation.

Rather it should an extra, so it can be installed with,

pip install ramp-engine[aws]

or something similar, same as it is currently done for the dask worker.

@agramfort
Copy link
Collaborator

agramfort commented May 9, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants