Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QR upload is needed for desktop-only flow #83

Closed
dandaka opened this issue Jan 5, 2022 · 2 comments
Closed

QR upload is needed for desktop-only flow #83

dandaka opened this issue Jan 5, 2022 · 2 comments
Labels
wontfix This will not be worked on

Comments

@dandaka
Copy link

dandaka commented Jan 5, 2022

Now

  1. User on desktop creates QR codes with app
  2. Wants to restore
  3. The only option is to scan QR with webcam

This flow expects either of those
a/ A second device with secrets on it (smartphone)
b/ A printer and printing action

Expected

UI allows uploading PNG files created by app

@dandaka
Copy link
Author

dandaka commented Jan 5, 2022

I see a related issue #72

@kirushik
Copy link
Contributor

kirushik commented Jan 6, 2022

No, sorry, this is not a feature which makes sense in context of BananaSplit.
The idea is to only allow users to have their QR codes as physical artifacts; under no circumstances should we encourage people to make a digital image of their QR code — it's notoriously hard to erase file without trace on any modern computing hardware, so it will inevitably lead to some users being compromised via hackers obtaining such QR codes copies and recovering the secrets.

It's pretty possible to split shards on a device without camera — but recovering on one should just not possible, and that's end of story.

I understand your struggle in context of #84 — now that's a legitimate bug we might at least try to address.

But this one is, unfortunately, won't fix .
If it's absolutely necessary to work with digital shares, some semi-synchronous multiparty protocol like https://darkcrystal.pw/ might be a better option.

@kirushik kirushik closed this as completed Jan 6, 2022
@kirushik kirushik added the wontfix This will not be worked on label Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants