From d6ae385b0981f95ddd9583057ee898a4a649d500 Mon Sep 17 00:00:00 2001
From: kogeler <25884155+kogeler@users.noreply.github.com>
Date: Wed, 23 Oct 2024 12:11:15 +0300
Subject: [PATCH] [node] fix app.kubernetes.io/version (#360)

* fix app.kubernetes.io/version

* fix docs

* fix docs
---
 charts/node/Chart.yaml             | 2 +-
 charts/node/README.md              | 2 +-
 charts/node/templates/_helpers.tpl | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/charts/node/Chart.yaml b/charts/node/Chart.yaml
index 4c610ee1..db119b04 100644
--- a/charts/node/Chart.yaml
+++ b/charts/node/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v2
 name: node
 description: A Helm chart to deploy Substrate/Polkadot nodes
 type: application
-version: 5.13.2
+version: 5.13.3
 maintainers:
   - name: Parity
     url: https://github.com/paritytech/helm-charts
diff --git a/charts/node/README.md b/charts/node/README.md
index 56e65bbc..bc34937a 100644
--- a/charts/node/README.md
+++ b/charts/node/README.md
@@ -18,7 +18,7 @@ This is intended behaviour. Make sure to run `git add -A` once again to stage ch
 
 # Substrate/Polkadot node Helm chart
 
-![Version: 5.13.2](https://img.shields.io/badge/Version-5.13.2-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)
+![Version: 5.13.3](https://img.shields.io/badge/Version-5.13.3-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)
 
 ## Overview
 The Polkadot Helm Chart provides a convenient way to deploy and manage a Polkadot blockchain node in a Kubernetes cluster.
diff --git a/charts/node/templates/_helpers.tpl b/charts/node/templates/_helpers.tpl
index 28a08dc2..7254f47a 100644
--- a/charts/node/templates/_helpers.tpl
+++ b/charts/node/templates/_helpers.tpl
@@ -37,7 +37,7 @@ Common labels
 helm.sh/chart: {{ include "node.chart" . }}
 {{ include "node.selectorLabels" . }}
 {{ include "node.serviceLabels" . }}
-app.kubernetes.io/version: {{ .Values.image.tag | replace ":" "-" | replace "@" "_" | trunc 63 | quote }}
+app.kubernetes.io/version: {{ .Values.image.tag | replace ":" "-" | replace "@" "_" | trunc 63 | trimSuffix "-" | trimSuffix "_" | quote }}
 app.kubernetes.io/managed-by: {{ .Release.Service }}
 {{- if or .Values.node.chainData.pruning ( not ( kindIs "invalid" .Values.node.chainData.pruning ) ) }}
 {{- if ge ( int .Values.node.chainData.pruning ) 1 }}