Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should TypeId always require eg Clone + 'static? #51

Open
jsdw opened this issue Mar 4, 2024 · 0 comments
Open

Should TypeId always require eg Clone + 'static? #51

jsdw opened this issue Mar 4, 2024 · 0 comments

Comments

@jsdw
Copy link
Collaborator

jsdw commented Mar 4, 2024

Eg in scale-value, we need to clone TypeIds. Requiring this.

paritytech/scale-value#45 (comment)

Perhaps in our DecodeAsType/DecodeAsFields (and the scale-encode versions) we should just constrain TypeId: Clone + Send + Sync + 'static or something like that, so our impls can rely on such things better.

This could also exist in scale-type-resolver itself.
@jsdw jsdw changed the title Should TypeId always require Clone + 'static? Should TypeId always require eg Clone + 'static? Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jsdw