Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup more trait bounds #363

Open
insipx opened this issue Oct 6, 2021 · 4 comments
Open

Cleanup more trait bounds #363

insipx opened this issue Oct 6, 2021 · 4 comments

Comments

@insipx
Copy link
Collaborator

insipx commented Oct 6, 2021

We can clean up trait bounds on our structs that we could not before due to Restioson/xtra#42

@dvdplm
Copy link
Contributor

dvdplm commented Nov 15, 2021

Is this still relevant? What structs do you have in mind here?

@insipx
Copy link
Collaborator Author

insipx commented Nov 15, 2021

Yeah! Still relevant. The PR I Linked allows us to remove the Send + Sync bounds from our Actor-struct declarations, like here for example:

pub struct BlocksIndexer<B: Send + 'static, D: Send + 'static> {

which will have a ripple effect and hopefully clean up the code elsewhere as well

@dvdplm
Copy link
Contributor

dvdplm commented Nov 15, 2021

I see, ok. But the PR is not released yet, so we can't do this yet right?

@insipx
Copy link
Collaborator Author

insipx commented Nov 15, 2021

yeah we're just waiting on a release of xtra. Not really high on priorities since it won't change the functionality of archive in any way other than improve the code quality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants