-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parseIsWeb doesn't work on WASM #1018
Comments
Thanks for opening this issue! |
@mbfakourii do you understand what is meant here? |
What they mean is the new wasm option, which is used to increase the output of Flutter Web. This feature is currently at the beginning of the work and many packages still do not support this feature, including the dependencies that are in the Parse Flutter project. |
Got it. So we'd need to wait until all the dependencies support the option before the Parse SDK can support it? |
Yes, we should wait |
Do we have to wait until all Parse SDK dependencies support the wasm option? Or is the issue only related to that one single code line that has been mentioned above, and is the solution to change
to
? |
No, all dependencies need to be supported |
I don't understand your response. Do you mean "Yes we need to wait for all dependency maintainers to support WASM, before we can support WASM?", or "No, we can make changes in our SDK to support WASM without waiting for the dependencies"? |
Do we have a list of packages that does not support WASM and is a dependency? |
Based on the reviews, we have a change in the parse_websocket_html.dart class. package_info_plus: ^5.0.1 => package_info_plus: ^6.0.0 parse_server_sdk: ^6.4.0 in parse_server_sdk_flutter => last version Dio must use dio_web_adapter: ^2.0.0 in last version Note that package_info_plus must be updated according to our versioning policy. |
I would be happy to help to make it wasm compatible. May be I need know where to start from. |
Most likely in Feb 2025 we will support Wasm. |
Why in Feb 2025? Is there anything blocking this done before that? |
For our versioning policy. |
To clarify, you can submit a PR at any time, but when it can be merged depends on its implications on our compatibility policy. |
const bool parseIsWeb = identical(0, 0.0);
fails on wasm.
Why not do the normal thing?
I see this code is dart and not flutter. Flutter does it this way which I assume works.
const bool parseIsWeb = bool.fromEnvironment('dart.library.js_util');
The text was updated successfully, but these errors were encountered: