Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for async FilesAdapter.getFileLocation #9268

Closed
mtrezza opened this issue Aug 9, 2024 · 4 comments · Fixed by #9271
Closed

Add support for async FilesAdapter.getFileLocation #9268

mtrezza opened this issue Aug 9, 2024 · 4 comments · Fixed by #9271
Labels
bounty:$10 Bounty applies for fixing this issue (Parse Bounty Program) state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version type:feature New feature or improvement of existing feature

Comments

@mtrezza
Copy link
Member

mtrezza commented Aug 9, 2024

New Feature / Enhancement Checklist

Current Limitation

The FilesAdapter protocol expects getFileLocation to be a synchronous method.

Feature / Enhancement Description

Add support for getFileLocation to be either an asynchronous or synchronous method:

Example Use Case

See parse-community/parse-server-s3-adapter#197.
@parse-github-assistant Parse GitHub Assistant
Copy link

Thanks for opening this issue!

  • 🎉 We are excited about your ideas for improvement!

@mtrezza mtrezza added the type:feature New feature or improvement of existing feature label Aug 9, 2024
@mtrezza mtrezza mentioned this issue Aug 9, 2024
Closed
@mtrezza mtrezza added the bounty:$10 Bounty applies for fixing this issue (Parse Bounty Program) label Aug 9, 2024
@abubkr-hago abubkr-hago mentioned this issue Aug 10, 2024
Closed
1 task
@vahidalizad vahidalizad mentioned this issue Aug 10, 2024
Merged
1 task
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.3.0-alpha.7

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Aug 27, 2024
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.3.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Oct 3, 2024
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.3.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Oct 3, 2024
@mtrezza mtrezza mentioned this issue Oct 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bounty:$10 Bounty applies for fixing this issue (Parse Bounty Program) state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version type:feature New feature or improvement of existing feature
Projects
None yet
Milestone
No milestone
2 participants
@mtrezza @parseplatformorg