From 0d1b6102925774fb3090fd6df6b328c1f87502b1 Mon Sep 17 00:00:00 2001 From: Joris Hulsbosch Date: Fri, 15 May 2020 15:32:27 +0200 Subject: [PATCH] fix: remove scrollbar because viewport is too high --- dist/styleguide/css/pattern-lab.css | 3 +- package-lock.json | 41 ++++++++++++++++++++------- source/scss/components/_viewport.scss | 3 +- 3 files changed, 32 insertions(+), 15 deletions(-) diff --git a/dist/styleguide/css/pattern-lab.css b/dist/styleguide/css/pattern-lab.css index 67db064..037cbe1 100644 --- a/dist/styleguide/css/pattern-lab.css +++ b/dist/styleguide/css/pattern-lab.css @@ -684,9 +684,8 @@ .pl-c-viewport { display: flex; flex-direction: column; - height: 100vh; width: 100%; - position: relative; + position: absolute; top: 2rem; bottom: 0; left: 0; diff --git a/package-lock.json b/package-lock.json index e3dae61..e34555e 100644 --- a/package-lock.json +++ b/package-lock.json @@ -771,7 +771,8 @@ "ansi-regex": { "version": "2.1.1", "bundled": true, - "dev": true + "dev": true, + "optional": true }, "aproba": { "version": "1.2.0", @@ -792,12 +793,14 @@ "balanced-match": { "version": "1.0.0", "bundled": true, - "dev": true + "dev": true, + "optional": true }, "brace-expansion": { "version": "1.1.11", "bundled": true, "dev": true, + "optional": true, "requires": { "balanced-match": "^1.0.0", "concat-map": "0.0.1" @@ -812,17 +815,20 @@ "code-point-at": { "version": "1.1.0", "bundled": true, - "dev": true + "dev": true, + "optional": true }, "concat-map": { "version": "0.0.1", "bundled": true, - "dev": true + "dev": true, + "optional": true }, "console-control-strings": { "version": "1.1.0", "bundled": true, - "dev": true + "dev": true, + "optional": true }, "core-util-is": { "version": "1.0.2", @@ -939,7 +945,8 @@ "inherits": { "version": "2.0.4", "bundled": true, - "dev": true + "dev": true, + "optional": true }, "ini": { "version": "1.3.5", @@ -951,6 +958,7 @@ "version": "1.0.0", "bundled": true, "dev": true, + "optional": true, "requires": { "number-is-nan": "^1.0.0" } @@ -965,6 +973,7 @@ "version": "3.0.4", "bundled": true, "dev": true, + "optional": true, "requires": { "brace-expansion": "^1.1.7" } @@ -972,12 +981,14 @@ "minimist": { "version": "0.0.8", "bundled": true, - "dev": true + "dev": true, + "optional": true }, "minipass": { "version": "2.9.0", "bundled": true, "dev": true, + "optional": true, "requires": { "safe-buffer": "^5.1.2", "yallist": "^3.0.0" @@ -996,6 +1007,7 @@ "version": "0.5.1", "bundled": true, "dev": true, + "optional": true, "requires": { "minimist": "0.0.8" } @@ -1085,7 +1097,8 @@ "number-is-nan": { "version": "1.0.1", "bundled": true, - "dev": true + "dev": true, + "optional": true }, "object-assign": { "version": "4.1.1", @@ -1097,6 +1110,7 @@ "version": "1.4.0", "bundled": true, "dev": true, + "optional": true, "requires": { "wrappy": "1" } @@ -1182,7 +1196,8 @@ "safe-buffer": { "version": "5.1.2", "bundled": true, - "dev": true + "dev": true, + "optional": true }, "safer-buffer": { "version": "2.1.2", @@ -1218,6 +1233,7 @@ "version": "1.0.2", "bundled": true, "dev": true, + "optional": true, "requires": { "code-point-at": "^1.0.0", "is-fullwidth-code-point": "^1.0.0", @@ -1237,6 +1253,7 @@ "version": "3.0.1", "bundled": true, "dev": true, + "optional": true, "requires": { "ansi-regex": "^2.0.0" } @@ -1280,12 +1297,14 @@ "wrappy": { "version": "1.0.2", "bundled": true, - "dev": true + "dev": true, + "optional": true }, "yallist": { "version": "3.1.1", "bundled": true, - "dev": true + "dev": true, + "optional": true } } }, diff --git a/source/scss/components/_viewport.scss b/source/scss/components/_viewport.scss index 082f77a..68e957a 100644 --- a/source/scss/components/_viewport.scss +++ b/source/scss/components/_viewport.scss @@ -15,9 +15,8 @@ .pl-c-viewport { display: flex; flex-direction: column; - height: 100vh; width: 100%; - position: relative; + position: absolute; top: $offset-top; bottom: 0; left: 0;