From a465b400e91ff108c162329338e4f26905d93bc9 Mon Sep 17 00:00:00 2001 From: Steven Spriggs Date: Mon, 23 Sep 2024 14:13:16 -0400 Subject: [PATCH 1/3] fix(jump-links): fix missing comma throwing off chrome css parser --- elements/pf-jump-links/pf-jump-links.css | 33 ++++++++++++++++-------- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/elements/pf-jump-links/pf-jump-links.css b/elements/pf-jump-links/pf-jump-links.css index d1deaff90d..eae6d4790b 100644 --- a/elements/pf-jump-links/pf-jump-links.css +++ b/elements/pf-jump-links/pf-jump-links.css @@ -46,18 +46,29 @@ slot::before { } :host([vertical]) #container { - --pf-c-jump-links__list--PaddingTop: var(--pf-c-jump-links--m-vertical__list--PaddingTop, - var(--pf-global--spacer--md, 1rem)); - --pf-c-jump-links__list--PaddingRight: var(--pf-c-jump-links--m-vertical__list--PaddingRight, 0); - --pf-c-jump-links__list--PaddingBottom: var(--pf-c-jump-links--m-vertical__list--PaddingBottom - var(--pf-global--spacer--md, 1rem)); - --pf-c-jump-links__list--PaddingLeft: var(--pf-c-jump-links--m-vertical__list--PaddingLeft, 0); - --pf-c-jump-links__list--before--BorderTopWidth: var(--pf-c-jump-links--m-vertical__list--before--BorderTopWidth, 0); - --pf-c-jump-links__list--before--BorderLeftWidth: var(--pf-c-jump-links--m-vertical__list--before--BorderLeftWidth, + --pf-c-jump-links__list--PaddingTop: + var(--pf-c-jump-links--m-vertical__list--PaddingTop, + var(--pf-global--spacer--md, 1rem) + ); + --pf-c-jump-links__list--PaddingRight: + var(--pf-c-jump-links--m-vertical__list--PaddingRight,0); + --pf-c-jump-links__list--PaddingBottom: + var(--pf-c-jump-links--m-vertical__list--PaddingBottom, + var(--pf-global--spacer--md, 1rem) + ); + --pf-c-jump-links__list--PaddingLeft: + var(--pf-c-jump-links--m-vertical__list--PaddingLeft, 0); + --pf-c-jump-links__list--before--BorderTopWidth: + var(--pf-c-jump-links--m-vertical__list--before--BorderTopWidth, 0); + --pf-c-jump-links__list--before--BorderLeftWidth: + var(--pf-c-jump-links--m-vertical__list--before--BorderLeftWidth, var(--pf-global--BorderWidth--sm, 1px)); - --pf-c-jump-links__item--m-current__link--before--BorderTopWidth: var(--pf-c-jump-links--m-vertical__item--m-current__link--before--BorderTopWidth, 0); - --pf-c-jump-links__item--m-current__link--before--BorderLeftWidth: var(--pf-c-jump-links--m-vertical__item--m-current__link--before--BorderLeftWidth, - var(--pf-global--BorderWidth--lg, 3px)); + --pf-c-jump-links__item--m-current__link--before--BorderTopWidth: + var(--pf-c-jump-links--m-vertical__item--m-current__link--before--BorderTopWidth, 0); + --pf-c-jump-links__item--m-current__link--before--BorderLeftWidth: + var(--pf-c-jump-links--m-vertical__item--m-current__link--before--BorderLeftWidth, + var(--pf-global--BorderWidth--lg, 3px) + ); --pf-c-jump-links__list--FlexDirection: var(--pf-c-jump-links--m-vertical__list--FlexDirection, column); } From 9f950022b11873a993253a8194506c7d19cc789c Mon Sep 17 00:00:00 2001 From: Steven Spriggs Date: Mon, 23 Sep 2024 14:20:20 -0400 Subject: [PATCH 2/3] chore(jump-links): add changeset --- .changeset/fresh-donuts-count.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/fresh-donuts-count.md diff --git a/.changeset/fresh-donuts-count.md b/.changeset/fresh-donuts-count.md new file mode 100644 index 0000000000..1de5a9f2e5 --- /dev/null +++ b/.changeset/fresh-donuts-count.md @@ -0,0 +1,5 @@ +--- +"@patternfly/elements": major +--- + +``: corrected incorrect styles From 87b4f7937d67f2e6117aece72ef44775e3335bc3 Mon Sep 17 00:00:00 2001 From: Steven Spriggs Date: Tue, 24 Sep 2024 09:17:44 -0400 Subject: [PATCH 3/3] chore(jump-links) update changeset MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Benny Powers - עם ישראל חי! --- .changeset/fresh-donuts-count.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/fresh-donuts-count.md b/.changeset/fresh-donuts-count.md index 1de5a9f2e5..352ba5a1d2 100644 --- a/.changeset/fresh-donuts-count.md +++ b/.changeset/fresh-donuts-count.md @@ -2,4 +2,4 @@ "@patternfly/elements": major --- -``: corrected incorrect styles +``: corrected a layout bug which occurred when the `centered` attribute applied