-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sorting Collection Table #450
base: master
Are you sure you want to change the base?
Conversation
…sorting-keywords-2
@pbylicki one unit test is failing and I can't get why. There is some error on mapping for Collection on update. Functional tests are passing, because CLI is not using update functionality. |
@MaciejWiczk I see two problems here that ideally could be solved in separate PRs.
Most of these changes are already present, but there are some additional parts that are not clear for me. |
Yes, currently we are using FE to get length of keywords array:
Yes, it's added to Collection, with FE somewhere change in my mind ;)
TBH I tried to make this work, I'm not fluent enough here, to grasp the proper way.
Two requests to be made separate (async), or to use store? What would You suggest? |
Added PR to isolate required backend changes: #451 |
resolves #146
I just extended frontend bit from @MarcinMaciaszek, but this is outside our areas of expertise ;)
One side effect I noticed is that left side panel get's sorted as well, when using sort on Collection Table: