Field capitalization doesnt work as expected

[operdeck]

pdstools version checks

• I have checked that this issue has not already been reported.

• I have confirmed this bug exists on the latest version of pdstools.

Issue description

From Grigoriy:
I noticed that capitalize function does not work as expected. It also capitalizes parts of words in the middle - like GroupvalIDitystartDate. I added that change in the notebook:
for word in capitalize_end_words:
fields_new = [re.sub(word + '\b', word, field, flags=re.I) for field in fields_new]
fields_new = [field[:1].upper() + field[1:] for field in fields_new]

Reproducible example

...

Expected behavior

...

Installed versions

v4

[StijnKas]

I would argue it does work as expected - the goal was to capitalize subwords - ID is one of those, so it should be capitalized. The short-term solution is just to add words like Validity and Start to the list of words to capitalize... Then we should be good, no?

[operdeck]

If it works like that we should be good. Of both ID and Identidy are in the list it should keep Identidy as is and not change to IDentity regardless order etc. Op do 19 dec 2024 om 10:28 schreef Stijn Kas ***@***.***>

…

I would argue it does work as expected - the goal was to capitalize subwords - ID is one of those, so it should be capitalized. The short-term solution is just to add words like Validity and Start to the list of words to capitalize... Then we should be good, no? — Reply to this email directly, view it on GitHub <#302 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABEVTKBM33TZXAQ7EHZOCB32GKGUBAVCNFSM6AAAAABT24PLM2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJTGE4DCOBQGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[StijnKas]

that should be the behavior, yes. if not, we should fix it; let's verify before closing the issue.