Method naming conflict with Field and FieldNot.

[alan-mcnaney]

Similarly named methods can cause auto-generated method naming conflicts. Specifically if an interface has a naming such as:

Field(string, interface{})
FieldNot(string, interface{})

While charlatan does code generation for Field(), it generates FieldCalled() and FieldNotCalled().

When charlatan attempts to generate methods for FieldNot(), it will generate FieldNotCalled() and draw a method definition naming conflict error, as there is already a FieldNotCalled() method defined by code generation for Field().

[kevinbirch]

I was browsing this project and thought I'd leave a note about one approach to solving this:

Using the example from the README:

type FakeService struct {
	QueryHook func(*QueryFilter) ([]*Thing, error)

	QueryCalls []*QueryInvocation
}

You could add a type for the invocation array, and move the query methods there:

type QueryInvocations []*QueryInvocation

func (i QueryInvocations) Called() bool {
	return len(i) != 0
}

func (i QueryInvocations) AssertCalled(t *testing.T) {
	t.Helper()
	 if len(i) == 0 {
		t.Error("FakeService.Query not called, expected at least one")
	}
}

// etc ...

type FakeService struct {
	QueryHook func(*QueryFilter) ([]*Thing, error)

	QueryCalls QueryInvocations
}