diff --git a/packages/core/src/install.js b/packages/core/src/install.js index 86a3ff30b..4ae9ecf1a 100644 --- a/packages/core/src/install.js +++ b/packages/core/src/install.js @@ -177,11 +177,11 @@ export function chromium({ // default chromium revisions corresponds to v123.0.6312.58 chromium.revisions = { - linux: '1368524', - win64: '1368503', - win32: '1368516', - darwin: '1368518', - darwinArm: '1368521' + linux: '1331481', + win64: '1331469', + win32: '1331487', + darwin: '1331485', + darwinArm: '1331488' }; // export the namespace by default diff --git a/packages/core/src/network.js b/packages/core/src/network.js index d527ce9ec..8e808ab01 100644 --- a/packages/core/src/network.js +++ b/packages/core/src/network.js @@ -17,7 +17,6 @@ class RequestLifeCycleHandler { this.resolveResponseReceived = null; this.requestWillBeSent = new Promise((resolve) => (this.resolveRequestWillBeSent = resolve)); this.responseReceived = new Promise((resolve) => (this.resolveResponseReceived = resolve)); - this.isWorker = false; } } // The Interceptor class creates common handlers for dealing with intercepting asset requests @@ -219,14 +218,6 @@ export class Network { let { requestId, request, type } = event; // do not handle data urls if (request.url.startsWith('data:')) return; - - const isWorker = type === 'Worker' || request.url.endsWith('.js'); - // Mark in the lifecycle handler if this is a worker request - this.#requestsLifeCycleHandler.get(requestId).isWorker = isWorker; - if (isWorker) { - this.log.debug(`Auto-resolving responseReceived for worker request: ${request.url}`); - this.#requestsLifeCycleHandler.get(requestId).resolveResponseReceived(); - } // Browsers handle URL encoding leniently. // This code checks for issues such as `%` and leading spaces and warns the user accordingly. decodeAndEncodeURLWithLogging(request.url, this.log, { @@ -309,12 +300,6 @@ export class Network { _handleLoadingFinished = async (session, event) => { let { requestId } = event; // wait for upto 2 seconds or check if response has been sent - const handler = this.#requestsLifeCycleHandler.get(requestId); - - // For worker requests, we don't need to wait for responseReceived - if (!handler.isWorker) { - await handler.responseReceived; - } let request = this.#requests.get(requestId); /* istanbul ignore if: race condition paranioa */ if (!request) return; diff --git a/packages/core/test/discovery.test.js b/packages/core/test/discovery.test.js index 27acf187b..bd9c0c77d 100644 --- a/packages/core/test/discovery.test.js +++ b/packages/core/test/discovery.test.js @@ -808,28 +808,14 @@ describe('Discovery', () => { self.addEventListener("message", async ({ data }) => { let response = await fetch(new Request(data)); self.postMessage("done"); - }); - `]); + })`]); server.reply('/', () => [200, 'text/html', dedent` - - - - - - - - - `]); + `]); await percy.snapshot({ name: 'worker snapshot',