Switch to luau-unzip #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daimond113
approved these changes
Jan 14, 2025
CompeyDev
requested changes
Jan 15, 2025
CompeyDev
requested changes
Jan 16, 2025
There was a problem hiding this comment.
A few final changes are required:
- Implicit "if not" checks for nil values should be explicit
~= - You should be able to safely remove
utils/exec.luau - Minor nitpick but CHANGELOG entries usually don't have trailing full-stops, the current entry looks a bit inconsistent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches to the
luau-unziplibrary for extracting ZIP archives, meaning we no longer need to rely on external programs, likeunzip. This should hopefully fix #2.It will now directly extract the executable from the archive, instead of extracting all of the contents to a temporary directory.
This PR also bumps
asphaltto v0.8.4 andseleneto v0.28.0.