Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Babel Configuration #32

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Babel Configuration #32

wants to merge 12 commits into from

Conversation

souravdasslg
Copy link
Collaborator

@souravdasslg souravdasslg commented Dec 5, 2019

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #4 and #29

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit Test
  • Integration Test

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

1. Create models and routes directory
2. Setup logger utility
3. Connected DB with Application

config: Configure babel for backend

config: Congigure babel for backend
Copy link
Contributor

@nimish-gupta nimish-gupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after some small changes.

server/app.js Outdated
@@ -1,18 +1,21 @@
/* eslint-disable import/no-dynamic-require */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove this comment.

@@ -43,6 +46,17 @@ app.use((err, req, res) => {
res.status(err.status || 500);
res.render('error');
});
mongoose.connect(process.env.DB_HOST, {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try to add the new lines after every block.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ill do that

yashpandit and others added 5 commits December 5, 2019 18:37
Add new Page - CreateNewRelay

Resolves: #24
1. Create models and routes directory
2. Setup logger utility
3. Connected DB with Application

config: Configure babel for backend

config: Congigure babel for backend
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 12432 lines exceeds the maximum allowed for the inline comments feature.

1. Create models and routes directory
2. Setup logger utility
3. Connected DB with Application

config: Configure babel for backend

config: Congigure babel for backend
1. Create models and routes directory
2. Setup logger utility
3. Connected DB with Application

config: Configure babel for backend

config: Congigure babel for backend
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 12615 lines exceeds the maximum allowed for the inline comments feature.

@codeclimate
Copy link

codeclimate bot commented Dec 6, 2019

Code Climate has analyzed commit 83fca8e and detected 0 issues on this pull request.

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add babel to the server side to use ES6 features.
2 participants