-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Babel Configuration #32
base: master
Are you sure you want to change the base?
Conversation
1. Create models and routes directory 2. Setup logger utility 3. Connected DB with Application config: Configure babel for backend config: Congigure babel for backend
6719ecd
to
f43d920
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after some small changes.
server/app.js
Outdated
@@ -1,18 +1,21 @@ | |||
/* eslint-disable import/no-dynamic-require */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can remove this comment.
@@ -43,6 +46,17 @@ app.use((err, req, res) => { | |||
res.status(err.status || 500); | |||
res.render('error'); | |||
}); | |||
mongoose.connect(process.env.DB_HOST, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please try to add the new lines after every block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ill do that
Add new Page - CreateNewRelay Resolves: #24
1. Create models and routes directory 2. Setup logger utility 3. Connected DB with Application config: Configure babel for backend config: Congigure babel for backend
…ts/batch-11-relayer into souravdasslg-issue4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 12432 lines exceeds the maximum allowed for the inline comments feature.
1. Create models and routes directory 2. Setup logger utility 3. Connected DB with Application config: Configure babel for backend config: Congigure babel for backend
1. Create models and routes directory 2. Setup logger utility 3. Connected DB with Application config: Configure babel for backend config: Congigure babel for backend
…ts/batch-11-relayer into souravdasslg-issue4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 12615 lines exceeds the maximum allowed for the inline comments feature.
Code Climate has analyzed commit 83fca8e and detected 0 issues on this pull request. View more on Code Climate. |
Pull Request Template
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #4 and #29
Type of change
How Has This Been Tested
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist