Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible issue with the repository and collaboration #8

Open
AlexanderFreeman opened this issue Feb 4, 2022 · 0 comments
Open

Possible issue with the repository and collaboration #8

AlexanderFreeman opened this issue Feb 4, 2022 · 0 comments

Comments

@AlexanderFreeman
Copy link

AlexanderFreeman commented Feb 4, 2022

I am very interested in your work, especially in developing chemical databases, such as ACCDB.

I studied the database files in the repository.

Possibly, it is an issue with several files that I cannot fully understand—for example, https://github.com/peverati/ACCDB/blob/master/Databases/MetalsEE/4d-SSIP24/DatasetEval.csv . According to the description of the 4d-ssip24 set itself, it should include subsets SS16 (16 reactions) and IP8 (8 reactions). And there is also a SSIP24 subset in this file (24 reactions), which completely duplicates the two previous ones up to all values and coefficients. Similar problems are observed in many other files.

Additionally, I compared the number of files in subsets mentioned in the article https://onlinelibrary.wiley.com/doi/abs/10.1002/jcc.25761 and in the README.md file in the repository. There are mismatches in several databases such as MGCDB84 and GMTKN55. Could you explain the cause of that? Are the databases presented in the repository consistent with the published article? Where could I find the last tested version of the database?

I will be very grateful to you if you answer these questions. Moreover, I am currently working on a project in this area and would like to collaborate with you also in expanding the available chemical databases and, possibly, improving their usability for machine learning problems.

@AlexanderFreeman AlexanderFreeman changed the title Possible issue with github ACCDB repository and collaboration Possible issue with the repository and collaboration Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant