-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #2645 (fix slice_derivation on empty dataset) #2646
Conversation
Ohh this is such an interesting find. Might be a good stress test for other functions?? @pharmaverse/admiral WDYT?? |
Hey @clarkliming are you still working on this PR? |
Hi @bms63 just updated; it do take some time to finish all these ticks |
We do like our tick boxes and standardize way of doing thing! 😀 Can you update the Pull Request title to have Closes #2646 (succinct title on what this addresses). Then we have nice messages in the main page. Click the Edit button to the right of the title. |
Hi @clarkliming just checking in on this PR - will you be able to complete it soon? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @clarkliming , looks good now.
Just the styler/lintr issue needs to be fixed.
@bundfussr after this is merged could we run admiral through the roche checks? |
Sure |
close #2645
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
main
branch until you have checked off each task.styler::style_file()
to style R and Rmd filesinst/cheatsheet/admiral_cheatsheet.pptx
and re-upload a PDF and a PNG version of it to the same folder. (The PNG version can be created by taking a screenshot of the PDF version.)devtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelyNEWS.md
under the header# admiral (development version)
if the changes pertain to a user-facing function (i.e. it has an@export
tag) or documentation aimed at users (rather than developers). A Developer Notes section is available inNEWS.md
for tracking developer-facing issues.pkgdown::build_site()
and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.lintr::lint_package()
R CMD check
locally and address all errors and warnings -devtools::check()