Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: adsl.Rmd vignette - lookup table for derive_vars_cat() #2647

Closed
Fanny-Gautier opened this issue Jan 17, 2025 · 3 comments · Fixed by #2650
Closed

Documentation: adsl.Rmd vignette - lookup table for derive_vars_cat() #2647

Fanny-Gautier opened this issue Jan 17, 2025 · 3 comments · Fixed by #2650
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@Fanny-Gautier
Copy link
Collaborator

Fanny-Gautier commented Jan 17, 2025

Please select a category the issue is focused on?

User Guides

Let us know where something needs a refresh or put your idea here!

In adsl.Rmd vignette there is the agegr1_lookup table used in derive_vars_cat() and is says that the "catch-all" conditions must be at the last place in the lookup table. Here it seems that it is when AGE is NOT missing, while in the corresponding look-up table it is when AGE is missing.
It's a bit confusing with the agegr1_lookup example. The explanation would be less confusing with the region1_lookup example which contains the condition !is.na(COUNTRY) , "Rest of the World", or updating the agegr1_lookup lookup table to be consistent as on 2nd screenshot.

Image

Image

@Fanny-Gautier Fanny-Gautier added the documentation Improvements or additions to documentation label Jan 17, 2025
@Fanny-Gautier
Copy link
Collaborator Author

@bms63, @bundfussr , @StefanThoma I am working on pharamverse/exemples for ADSL and have the above query.

@bundfussr
Copy link
Collaborator

Yes, I agree, we should use the region1_lookup example in the text.

@StefanThoma
Copy link
Collaborator

Yes, I agree

@StefanThoma StefanThoma self-assigned this Jan 20, 2025
@StefanThoma StefanThoma linked a pull request Jan 21, 2025 that will close this issue
15 tasks
bundfussr pushed a commit that referenced this issue Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Development

Successfully merging a pull request may close this issue.

3 participants