Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pharo build is broken #17332

Closed
Ducasse opened this issue Oct 30, 2024 · 5 comments
Closed

Pharo build is broken #17332

Ducasse opened this issue Oct 30, 2024 · 5 comments
Labels
Priority: Critical To fix or review as soon as possible Type: Bug

Comments

@Ducasse
Copy link
Member

Ducasse commented Oct 30, 2024

Apparently the build is broken.
Now I do not understand why because I did not change anything in the pharo13 branch of Microdown.

NewUndeclaredWarning: Microdown class>>asRichText: (MicRichTextComposer is Undeclared)
NewUndeclaredWarning: MicElement>>propertyAt: (MicPropertyError is Undeclared)
NewUndeclaredWarning: MicElement>>removeProperty: (MicPropertyError is Undeclared)
NewUndeclaredWarning: MicFigureBlock>>hasCaption (captionElements is Undeclared)
MetacelloNotification: Loaded -> Microdown --- github://pillar-markup/Microdown:Pharo13/src(e390aeb)
MetacelloNotification: Loaded -> Microdown-Tests --- github://pillar-markup/Microdown:Pharo13/src(e390aeb)
MetacelloNotification: Loaded -> Microdown-RichTextComposer --- github://pillar-markup/Microdown:Pharo13/src(e390aeb)
 postload �[31mUndeclaredVariableRead: Attempt to read undeclared variable IceRepository
�[0mUndeclaredVariable>>runtimeUndeclaredReadInContext:
BaselineOfMicrodown>>postload:package:
[ :aLoader :pkgSpec | self project configuration perform: selector with: aLoader with: pkgSpec ] in MetacelloVersionSpec(MetacelloSpec)>>doItBlock: in Block: [ :aLoader :pkgSpec | self project configurati[..]
FullBlockClosure(BlockClosure)>>valueWithPossibleArgs:
MetacelloLoadTarget>>visitPostLoadDirective:
MetacelloPostLoadDirective>>acceptVisitor:
[ :dir |
		dir acceptVisitor: self ] in MetacelloLoadTarget>>visitLinearLoadDirective: in Block: [ :dir |...
OrderedCollection>>do:
MetacelloLoadTarget>>visitLinearLoadDirective:
MetacelloLinearLoadDirective>>acceptVisitor:
MetacelloVersion>>loadRequiredFromArray:withEngine:
[
@Ducasse Ducasse added Type: Bug Priority: Critical To fix or review as soon as possible labels Oct 30, 2024
@Ducasse
Copy link
Member Author

Ducasse commented Oct 30, 2024

So apparently this is not in the microdown baseline in Pharo but in the baseline in the microdown repo.

@Ducasse
Copy link
Member Author

Ducasse commented Oct 30, 2024

I do not get why Attempt to read undeclared variable IceRepository

BaselineOfMicrodown >> postload: loader package: packageSpec

	| p |
	self class name, ' postload ' traceCr. 

	p := (IceRepository repositoryNamed: 'microdown').
	p ifNil: [ p :=  (IceRepository repositoryNamed: 'Microdown') ].
	[ 
	(p ifNotNil: [ :p2 | (p2 packageNamed: 'BaselineOfMicrodown') reload ]) 
	] 
		on: MCMergeOrLoadWarning 
		do: [ :ex | ex load ]

@hernanmd
Copy link
Member

Something like this?

postload: loader package: packageSpec

	| repo |
	self class name, ' postload ' traceCr. 
	repo := (self class environment classNamed: #IceRepository)
		        ifNotNil: [ :iceberg |
			        iceberg registry
				        detect: [ :each | each name = 'Microdown' ]
				        ifNone: [ nil ] ].

	[ repo ifNotNil: [ :p2 | (p2 packageNamed: 'BaselineOfMicrodown') reload ] ] 
	on: MCMergeOrLoadWarning 
	do: [ :ex | ex load ]

@jecisc
Copy link
Member

jecisc commented Oct 30, 2024

I did a PR to fix this: pillar-markup/Microdown#909

@hernanmd
Copy link
Member

hernanmd commented Nov 7, 2024

Fixed, although some problems persists: #17348

@hernanmd hernanmd closed this as completed Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Critical To fix or review as soon as possible Type: Bug
Projects
None yet
Development

No branches or pull requests

3 participants