Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asymmetric tiling padding implementation for faster results #63

Open
sujeendran opened this issue Jan 10, 2025 · 0 comments
Open

Asymmetric tiling padding implementation for faster results #63

sujeendran opened this issue Jan 10, 2025 · 0 comments

Comments

@sujeendran
Copy link

Hi,

I have been trying out this workflow in replicate and comfy-ui and found the results to be pretty good. Only problem I see is that when pattern is enabled, it takes a lot more time (4x more time for 2x upscaling a 1024x512 image). I looked around the implementation and noticed the code was performing tiled decoding when pattern is enabled. When I tried other regular SDXL workflows, enabling circular padding on Conv2d layers for seamless patterns doesn't cost any extra time and works perfectly almost everytime. Would it be possible to have a similar implementation here as it would be better, faster, simpler and more efficient than tiling+offsetting+etc.?

If I knew where to modify the diffuser pipeline object, I would have done it myself and raised a PR but I haven't got my head around this repo setup. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant