Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a delimiter between post title and author name #431

Open
nir-arad opened this issue Sep 9, 2020 · 1 comment
Open

Add a delimiter between post title and author name #431

nir-arad opened this issue Sep 9, 2020 · 1 comment
Labels

Comments

@nir-arad
Copy link

nir-arad commented Sep 9, 2020

This issue is currently exhibited in this page
Post titles and author names are in Hebrew.

Expected behavior

There should be a between post title and author name.
A nice-to-have feature is a configurable delimiter, either as a selection (dash, colon, ...) or in free form.

Actual behavior

The author name is shown immediately after the post name, with no space.

Shortcode used and steps to reproduce the behavior

  • Create a post
  • Classify into a category
  • Create a page
  • Add shortcode:
    [catlist name="0002" author=yes pagination=no numberposts=500 orderby=title]

WP version, LCP plugin version (versions of other software if relevant, e.g. PHP)

PHP 7.3.15
WP 5.5.1
LCP 0.83.1

(If you want to submit a feature request, delete the sections above and describe the suggested feature.)

@nir-arad nir-arad changed the title Add a delimiter between post name and author Add a delimiter between post title and author name Sep 9, 2020
@stale stale bot added the wontfix label Nov 8, 2020
@stale stale bot closed this as completed Nov 15, 2020
@klemens-st
Copy link
Collaborator

I think we can safely add an automatic whitespace before all elements. It should be implemented in a dedicated function to keep things DRY and to make sure it's always added the same way.

If we prepend the whitespace before any user specified tags, it won't affect HTML and CSS customisations, so it's absolutely safe to implement. Browsers drop whitespace characters between block elements anyway.

I've seen many users trying to achieve a similar thing with CSS or a custom template but to make a simple shortcode usable out of the box, this feature should be implemented in the base plugin.

@klemens-st klemens-st reopened this Mar 20, 2021
@stale stale bot removed the wontfix label Mar 20, 2021
Repository owner deleted a comment from stale bot Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants