Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dm: update DM quick start using TiUP Playground #19637

Merged
merged 7 commits into from
Jan 23, 2025
Merged

dm: update DM quick start using TiUP Playground #19637

merged 7 commits into from
Jan 23, 2025

Conversation

lilin90
Copy link
Member

@lilin90 lilin90 commented Jan 21, 2025 •
edited
Loading

What is changed, added or deleted? (Required)

This PR updates the TiDB Data Migration Quick Start guide. Changes include:

  • Replacing binary-based deployment instructions with TiUP Playground to simplify setup.
  • Adding detailed steps for preparing source databases on Docker, macOS, CentOS, and Ubuntu.
  • Simplifying and clarifying the steps for DM configuration and task creation.
  • Adding explicit cleanup instructions and actionable examples to improve usability.

These changes aim to make the guide more accurate, complete, and easier to follow for users setting up a local data migration environment.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@lilin90 lilin90 added needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. translation/from-docs This PR is translated from a PR in pingcap/docs. type/enhancement The issue or PR belongs to an enhancement. labels Jan 21, 2025
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 21, 2025
@lilin90 lilin90 self-assigned this Jan 21, 2025
@lilin90 lilin90 marked this pull request as draft January 21, 2025 09:14
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 21, 2025
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 22, 2025
@lilin90 lilin90 marked this pull request as ready for review January 22, 2025 09:56
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 22, 2025
GMHDBJD
GMHDBJD approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 23, 2025
Oreoxmt
Oreoxmt reviewed Jan 23, 2025
View reviewed changes
dm/quick-start-with-dm.md Outdated Show resolved Hide resolved
Oreoxmt
Oreoxmt reviewed Jan 23, 2025
View reviewed changes
dm/quick-start-with-dm.md Outdated Show resolved Hide resolved
Oreoxmt
Oreoxmt reviewed Jan 23, 2025
View reviewed changes
dm/quick-start-with-dm.md Outdated Show resolved Hide resolved
Oreoxmt
Oreoxmt reviewed Jan 23, 2025
View reviewed changes
dm/quick-start-with-dm.md Outdated Show resolved Hide resolved
Oreoxmt
Oreoxmt reviewed Jan 23, 2025
View reviewed changes
dm/quick-start-with-dm.md Outdated Show resolved Hide resolved
Oreoxmt
Oreoxmt reviewed Jan 23, 2025
View reviewed changes
dm/quick-start-with-dm.md Outdated Show resolved Hide resolved
Oreoxmt
Oreoxmt reviewed Jan 23, 2025
View reviewed changes
dm/quick-start-with-dm.md Outdated Show resolved Hide resolved
Oreoxmt
Oreoxmt reviewed Jan 23, 2025
View reviewed changes
dm/quick-start-with-dm.md Outdated Show resolved Hide resolved
Oreoxmt
Oreoxmt reviewed Jan 23, 2025
View reviewed changes
dm/quick-start-with-dm.md Outdated Show resolved Hide resolved
Oreoxmt
Oreoxmt reviewed Jan 23, 2025
View reviewed changes
dm/quick-start-with-dm.md Outdated Show resolved Hide resolved
Oreoxmt
Oreoxmt reviewed Jan 23, 2025
View reviewed changes
dm/quick-start-with-dm.md Outdated Show resolved Hide resolved
Oreoxmt
Oreoxmt reviewed Jan 23, 2025
View reviewed changes
dm/quick-start-with-dm.md Outdated Show resolved Hide resolved
Oreoxmt
Oreoxmt reviewed Jan 23, 2025
View reviewed changes
dm/quick-start-with-dm.md Outdated Show resolved Hide resolved
Oreoxmt
Oreoxmt approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 23, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 23, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-23 03:03:31.164762997 +0000 UTC m=+322738.495682401: ☑️ agreed by GMHDBJD.
  • 2025-01-23 03:34:48.411642284 +0000 UTC m=+324615.742561683: ☑️ agreed by Oreoxmt.

lilin90
lilin90 commented Jan 23, 2025
View reviewed changes
dm/quick-start-with-dm.md Outdated Show resolved Hide resolved
@lilin90
Copy link
Member Author

lilin90 commented Jan 23, 2025

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 23, 2025
@ti-chi-bot ti-chi-bot bot merged commit 5be170b into pingcap:master Jan 23, 2025
7 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #19679.

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jan 23, 2025
@lilin90 @ti-chi-bot
This is an automated cherry-pick of pingcap#19637
237ae2e 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 23, 2025
Merged
15 tasks
@lilin90 lilin90 deleted the quick-start-dm-playground-19925 branch January 23, 2025 07:05
ti-chi-bot bot pushed a commit that referenced this pull request Jan 23, 2025
@ti-chi-bot
dm: update DM quick start using TiUP Playground (#19637) (#19679)
d793da2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@Benjamin2037 Benjamin2037 Awaiting requested review from Benjamin2037

Assignees

@lilin90 lilin90

Labels
approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. translation/from-docs This PR is translated from a PR in pingcap/docs. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lilin90 @ti-chi-bot @GMHDBJD @Oreoxmt