From 47dd33891cde40112ac85874c42d8b720bea4238 Mon Sep 17 00:00:00 2001 From: hillium Date: Tue, 9 Jan 2024 14:30:28 +0800 Subject: [PATCH] address comments Signed-off-by: hillium --- pkg/brpb/brpb.pb.go | 5 ++++- proto/brpb.proto | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/pkg/brpb/brpb.pb.go b/pkg/brpb/brpb.pb.go index 4b1cef81d..432d9607f 100644 --- a/pkg/brpb/brpb.pb.go +++ b/pkg/brpb/brpb.pb.go @@ -35,7 +35,10 @@ const _ = proto.ProtoPackageIsVersion3 // please upgrade the proto package type PrepareSnapshotBackupRequestType int32 const ( - // Update the lease of suspending new ingest / admin commands to be proposed. + // Update the lease of suspending some commands (Which may impact the + // disk snapshot backup) to be proposed. + // As long as the lease is kept, those commands may not be proposed. + // If the client has gone, the lease will be destroyed after its TTL. PrepareSnapshotBackupRequestType_UpdateLease PrepareSnapshotBackupRequestType = 0 // Wait a region apply to the last index. PrepareSnapshotBackupRequestType_WaitApply PrepareSnapshotBackupRequestType = 1 diff --git a/proto/brpb.proto b/proto/brpb.proto index bc6d0328c..447ee3541 100644 --- a/proto/brpb.proto +++ b/proto/brpb.proto @@ -16,7 +16,10 @@ option (rustproto.lite_runtime_all) = true; option java_package = "org.tikv.kvproto"; enum PrepareSnapshotBackupRequestType { - // Update the lease of suspending new ingest / admin commands to be proposed. + // Update the lease of suspending some commands (Which may impact the + // disk snapshot backup) to be proposed. + // As long as the lease is kept, those commands may not be proposed. + // If the client has gone, the lease will be destroyed after its TTL. UpdateLease = 0; // Wait a region apply to the last index. WaitApply = 1;