Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify protobuf generation options #1278

Closed
overvenus opened this issue Nov 13, 2024 · 1 comment · Fixed by #1275
Closed

Unify protobuf generation options #1278

overvenus opened this issue Nov 13, 2024 · 1 comment · Fixed by #1275

Comments

@overvenus
Copy link
Member

The protobuf generation options are currently misaligned with tipb, resulting in an inconsistency between the struct and API definition, which may cause confusion and increase maintenance burdens.

While it may not provide performance improvements, I believe it's still beneficial to unify these options. One noticeable benefit is that we can reduce bloated code by removing unused fields.

XXX_NoUnkeyedLiteral struct{} `json:"-"`
XXX_unrecognized     []byte   `json:"-"`
XXX_sizecache        int32    `json:"-"`
@overvenus
Copy link
Member Author

Closed by #1275

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant