From 473bf80ad4f2765884fbe0deb9f5c1c268c4cf07 Mon Sep 17 00:00:00 2001
From: Sparkle <1284531+baurine@users.noreply.github.com>
Date: Fri, 29 Dec 2023 19:31:39 +0800
Subject: [PATCH] fix: remove duplicated `v` in version showing in the banner
 (#1634)

---
 .../src/dashboardApp/layout/main/Sider/Banner.tsx           | 6 +++++-
 .../src/dashboardApp/layout/main/Sider/Banner.tsx           | 6 +++++-
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/ui/packages/tidb-dashboard-for-clinic-cloud/src/dashboardApp/layout/main/Sider/Banner.tsx b/ui/packages/tidb-dashboard-for-clinic-cloud/src/dashboardApp/layout/main/Sider/Banner.tsx
index 479dceda4e..aee53cf807 100644
--- a/ui/packages/tidb-dashboard-for-clinic-cloud/src/dashboardApp/layout/main/Sider/Banner.tsx
+++ b/ui/packages/tidb-dashboard-for-clinic-cloud/src/dashboardApp/layout/main/Sider/Banner.tsx
@@ -35,7 +35,11 @@ function parseVersion(i: InfoInfoResponse, t: TFunction) {
     }
     if (i.version.internal_version) {
       // e.g. v2020.07.01.1
-      return `v${i.version.internal_version}`
+      if (i.version.internal_version.startsWith('v')) {
+        return i.version.internal_version
+      } else {
+        return `v${i.version.internal_version}`
+      }
     }
     return null
   }
diff --git a/ui/packages/tidb-dashboard-for-op/src/dashboardApp/layout/main/Sider/Banner.tsx b/ui/packages/tidb-dashboard-for-op/src/dashboardApp/layout/main/Sider/Banner.tsx
index 479dceda4e..aee53cf807 100644
--- a/ui/packages/tidb-dashboard-for-op/src/dashboardApp/layout/main/Sider/Banner.tsx
+++ b/ui/packages/tidb-dashboard-for-op/src/dashboardApp/layout/main/Sider/Banner.tsx
@@ -35,7 +35,11 @@ function parseVersion(i: InfoInfoResponse, t: TFunction) {
     }
     if (i.version.internal_version) {
       // e.g. v2020.07.01.1
-      return `v${i.version.internal_version}`
+      if (i.version.internal_version.startsWith('v')) {
+        return i.version.internal_version
+      } else {
+        return `v${i.version.internal_version}`
+      }
     }
     return null
   }