Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using graphics-smooth with pixi-legacy 6.5 with typescript won't build #30

Open
branj opened this issue Dec 16, 2022 · 2 comments
Open

Comments

@branj
Copy link

branj commented Dec 16, 2022

Hey, thanks for this project. Just wanted to share a potential issue:

I upgraded to [email protected] (to prep for 7 and offer canvas fallback support) and was getting errors out of the graphics-smooth lib when trying to build (this is a TS project):

node_modules/@pixi/graphics-smooth/index.d.ts:225:22 - error TS2415: Class 'SmoothGraphics' incorrectly extends base class 'Container<DisplayObject>'.
  Property '_renderCanvas' is protected in type 'SmoothGraphics' but public in type 'Container<DisplayObject>'.

225 export declare class SmoothGraphics extends Container {

This is from @pixi/graphics-smooth/index.d.ts
Screen Shot 2022-12-16 at 3 06 02 PM

I experimented with many different versions to come to the conclusion I think it's an actual issue. Changing _renderCanvas to public, or simply removing any access modifiers fixed this issue.

@miltoncandelero
Copy link

I am not sure this can work with pixijs legacy... the whole point of this package is to use super cool shaders that don't exist on canvas 🤔

@ivanpopelyshev
Copy link
Contributor

yeah, we should fix it, canvas is "legacy" in only one meaning - it was in core, now its separated. We still need it at least for the tests against Skia.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants