Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mask input as default #195

Closed
CatchABus opened this issue Sep 13, 2024 · 2 comments · Fixed by #205
Closed

Mask input as default #195

CatchABus opened this issue Sep 13, 2024 · 2 comments · Fixed by #205
Labels
enhancement New feature or request

Comments

@CatchABus
Copy link
Collaborator

CatchABus commented Sep 13, 2024

Please Describe The Problem To Be Solved
Right now, input mask seems to be disabled by default. As a result, input text overlaps input as it grows.
This seems to be configurable with addMask property but this is not even documented.

(Optional): Suggest A Solution
Set addMask property default to true. This way, input will function just like a regular form input.

@CatchABus CatchABus added the enhancement New feature or request label Sep 13, 2024
@CyberDex CyberDex linked a pull request Nov 28, 2024 that will close this issue
@CyberDex
Copy link
Member

It was by default before but was removed as adding a mask to each input can affect the rendering performance as each mask adds one more draw call and breaks the batch. So now it is optional, and you can enable it only when you know what you are doing and ensure it will be OK with your rendering. I documented the setting, though; thank you!

@CatchABus
Copy link
Collaborator Author

It was by default before but was removed as adding a mask to each input can affect the rendering performance as each mask adds one more draw call and breaks the batch. So now it is optional, and you can enable it only when you know what you are doing and ensure it will be OK with your rendering. I documented the setting, though; thank you!

Thank you so much for the detailed explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants