Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A subtle issue when calculating t-student kernel #7

Open
AlfredTino opened this issue Feb 5, 2021 · 1 comment
Open

A subtle issue when calculating t-student kernel #7

AlfredTino opened this issue Feb 5, 2021 · 1 comment

Comments

@AlfredTino
Copy link

Thank you for providing such a sophisticated toolbox for the community!
When I was studying the code, I found a subtle issue: models.layers line 156. In fact, when calculating t-student kernel, one should multiple gamma with squared d. However, here you square the product of gamma and d. I do not evaluate the effect now.

@pkorus
Copy link
Owner

pkorus commented Feb 17, 2021

Thanks for reporting this. I'll keep this mind before the next release.

@pkorus pkorus assigned pkorus and unassigned pkorus Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants