Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninstaller courrupt launcher file if launcher is opened while uninstallation #2312

Open
Akamig opened this issue Sep 13, 2023 · 0 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@Akamig
Copy link
Member

Akamig commented Sep 13, 2023

Issue

Basically, uninstaller is not properly uninstalling launcher when launcher is opened while removal.

Problem

Not only NSIS script of uninstaller does not handling process state at all, it doesn't checking the integrity of the removal result, making leftover files which disrupts reinstall.

Risk

We need to adopt custom written NSIS script in order to resolve this issue, but it seems NSIS itself have numerous problems with handling running process tree, which possibly resulting

  • Not removing files at all
  • Not closing running process (launcher in this case)
  • Removing wrong file
  • Break BOTH uninstaller / installer totally.

So there's very, very high risk underlying on this issue. need to tread very carefully.

@Akamig Akamig added the bug Something isn't working label Sep 13, 2023
@Akamig Akamig self-assigned this Sep 13, 2023
@Akamig Akamig moved this to In Progress in Nine Chronicles DX Team Sep 13, 2023
@Akamig Akamig changed the title Uninstaller does not properly work if launcher is opened while uninstallation Uninstaller courrupt launcher file if launcher is opened while uninstallation Sep 13, 2023
@longfin longfin moved this from In Progress to Todo in Nine Chronicles DX Team Sep 14, 2023
@Akamig Akamig moved this from Todo to In Progress in Nine Chronicles DX Team Sep 18, 2023
@Akamig Akamig moved this from In Progress to Todo in Nine Chronicles DX Team Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

1 participant