Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make build process more robust #10

Closed
opticyclic opened this issue Jun 13, 2019 · 2 comments
Closed

Make build process more robust #10

opticyclic opened this issue Jun 13, 2019 · 2 comments

Comments

@opticyclic
Copy link

opticyclic commented Jun 13, 2019

The README in the scripts directory says:

 You also need to download the Microsoft Azure, Cloud and Enterprise Symbol / Icon Set and copy all files from Symbols\CnE_Cloud\SVG to source/official

The current file is Microsoft_Cloud_AI_Azure_Service_Icon_Set_2019_05_08_2.zip

This no longer has the Symbols\CnE_Cloud\SVG directory.

If you extract the zip as is the build fails.

If you extract the zip using the flat option, most but not all of the files are found.

Some of the files that are in the manual directory are now also in the official directory.
e.g. manual/Azure App Service - Web App (was Websites) is official/App Services

This means that the build is not reproducible.

You need a way to ensure consistency.
A few different ways you could do this is:

  • check in all the files from the official version you used with a reference to the version number
  • put a direct link to the version of the official zip file used (assuming that Microsoft keeps archives)
  • Mirror the zips in another repo and link to the git hash (to save repo space in this repo)

etc

@Potherca Potherca changed the title Check In All Azure Icons Make build process more robust Mar 29, 2021
@Potherca Potherca added this to the v2.2.0 milestone May 2, 2021
@Potherca
Copy link
Member

@opticyclic Would these issues be resolved by the (code) changes in #31 ?

If so, we could close this issue once the MR is merged.

@Potherca
Copy link
Member

Potherca commented Jan 4, 2022

I am closing this issue, due to lack of response. I this still turns out to be an issue, it can always be reopened on request.

@Potherca Potherca closed this as completed Jan 4, 2022
@Potherca Potherca moved this to Done in All Projects Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants