Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expects that platformsh/upsun binary is in PATH #147

Open
shyim opened this issue Nov 6, 2023 · 3 comments
Open

Expects that platformsh/upsun binary is in PATH #147

shyim opened this issue Nov 6, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@shyim
Copy link

shyim commented Nov 6, 2023

❯ ../upsun push
Selected project: test (ismaivrbmrny6)

Pushing HEAD to the environment main (type: production) of project test (ismaivrbmrny6)

Are you sure you want to continue? [Y/n] Y

  fish: Unknown command: upsun
  fish:
  upsun ssh-cert:load --refresh-only --yes --quiet 2>/dev/null
  ^~~~^

Upsun should not expect himself in the PATH and should use the called binary aka arg 0 for further execution.

@akalipetis
Copy link
Member

Using arg 0 would not work in that case, as the SSH daemon (that needs to refresh the SSH keys) will not be in the same directory as you when executing that command.

An alternative approach would be to try to get the absolute path and use that if it's a command that needs to use it (ie certificate refresh, calling on itself, etc, while keeping the existing binary config option for documentation purposes.

WDYT @pjcdawkins?

@akalipetis akalipetis added the bug Something isn't working label Nov 27, 2023
@pjcdawkins
Copy link
Contributor

Note the listed error is actually upsun calling ssh, and then ssh calling upsun. There wouldn't be a way to use arg 0 in this case. Perhaps we could configure SSH with an absolute path to upsun, but that could be fragile.

@shyim
Copy link
Author

shyim commented Nov 28, 2023

check that the dir is in PATH and add when not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants