Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Idea: Rate-limiting #98

Open
simenandre opened this issue May 22, 2022 · 1 comment
Open

Feature Idea: Rate-limiting #98

simenandre opened this issue May 22, 2022 · 1 comment

Comments

@simenandre
Copy link

Hello 👋

Thanks for this awesome package. It really helps us out with our integration between Timely and Tripletex!

Due to the number of requests that we run towards the Timely API, we're hitting the rate-limiting functionality of the API. I've implemented a simple retry script that listens for status code 429 and uses retry-after header to determine when to try again. Maybe this should be implemented in this client instead?

Would you consider a contribution from me on this?

My retry thing can be found here:
https://gist.github.com/cobraz/7716c83da0c71edfd535c4e19d331691

@noticeeverything
Copy link
Contributor

@simenandre Thanks so much for the feedback and please accept our apology for the super late response! I just learned that you have to actually watch your own repo to get notifications about it 🤦. We're pretty short on resources (if our response time doesn't speak for itself), but we'd be happy to look at a PR if there's any chance you haven't solved this problem by now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants