Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nametag visibility is not persisted #4669

Open
ghost opened this issue Dec 22, 2021 · 2 comments · May be fixed by #5122
Open

Nametag visibility is not persisted #4669

ghost opened this issue Dec 22, 2021 · 2 comments · May be fixed by #5122
Labels
Category: Core Related to internal functionality Easy task Probably really easy to do, good task for first-time contributors Status: Debugged Cause of the bug has been found, but not fixed

Comments

@ghost
Copy link

ghost commented Dec 22, 2021

Issue description

  • Expected result: After rebooting, all attributes of entities and humans should save.
  • Actual result: After rebooting, all entities should have attributes...

Steps to reproduce the issue

  1. Make a simple plugin for creating Entity such as Human: $npc = new Human($sender->getServer()->getPlayerExact($sender->getName())->getLocation(), $sender->getServer()->getPlayerExact($sender->getName())->getSkin());

  2. Give for your Human nameTag: $npc->setNameTag("7776661111");

  3. Set nameTag of your Human always visible: $npc->setNameTagAlwaysVisible();

  4. Restart server.

  5. It happened that should have been expects. nameTag is not always displayed, only when you hover on it.

OS and versions

  • PocketMine-MP: 4.0.3
  • PHP: 8.0
  • Using JIT: no
  • Server OS: Linux Mint
@dktapps dktapps changed the title Humans (or) and Entities lose attributes after rebooting the server. Nametag visibility is not persisted Dec 22, 2021
@dktapps dktapps added Category: Core Related to internal functionality Status: Debugged Cause of the bug has been found, but not fixed labels Dec 27, 2021
@Julooooooos
Copy link

Still have this issue with Pocketmine 4.2.1... Is it therefore expected to be resolved?

@ghost

This comment was marked as spam.

Sign in to view
@dktapps dktapps added the Easy task Probably really easy to do, good task for first-time contributors label May 21, 2022
@IvanCraft623 IvanCraft623 linked a pull request Jun 30, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: Core Related to internal functionality Easy task Probably really easy to do, good task for first-time contributors Status: Debugged Cause of the bug has been found, but not fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Save and read CustomNameAlwaysVisible tag IvanCraft623/PocketMine-MP
2 participants
@dktapps @Julooooooos