Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Details broken for blocks/chains with V1 Weight #11040

Closed
MPM1107 opened this issue Oct 27, 2024 · 3 comments · Fixed by #11225
Closed

Block Details broken for blocks/chains with V1 Weight #11040

MPM1107 opened this issue Oct 27, 2024 · 3 comments · Fixed by #11225
Assignees
Labels
Bug Tracks issues causing errors or unintended behavior, critical to fix for reliability. P1 - High Essential for progress, blocks other tasks. Must be completed soon to maintain project flow.

Comments

@MPM1107
Copy link

MPM1107 commented Oct 27, 2024

The Block Details tab in the explorer throws an error for chains still using V1Weight, and all chains if looking up an old block that still used V1. The error thrown is v2Weight.proofSize.toBn is not a function. I suspect this was caused by #10639, when a V1 Weight object is automatically converted to V2, the proofSize of the result gets set to BN_ZERO, which seems to not have a toBn method I assume? Not sure what the correct way to go about fixing this would be, so opening this issue instead of submitting a PR.

@TarikGul TarikGul added Bug Tracks issues causing errors or unintended behavior, critical to fix for reliability. P1 - High Essential for progress, blocks other tasks. Must be completed soon to maintain project flow. labels Oct 30, 2024
@TarikGul
Copy link
Member

Can you provide a chain that is still using V1 so we can get this tested and fixed?

@MPM1107
Copy link
Author

MPM1107 commented Jan 17, 2025

3DPass is one currently using it, first in the list for me under "Live networks". Block details link

You can also test on other networks (like polkadot for example) by just going to a very old block that was still on v1, example

@polkadot-js-bot
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jan 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Tracks issues causing errors or unintended behavior, critical to fix for reliability. P1 - High Essential for progress, blocks other tasks. Must be completed soon to maintain project flow.
Development

Successfully merging a pull request may close this issue.

4 participants