Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Voice State object has no id field on ddc #430

Closed
kozabrada123 opened this issue Oct 15, 2023 · 1 comment · Fixed by #446
Closed

Voice State object has no id field on ddc #430

kozabrada123 opened this issue Oct 15, 2023 · 1 comment · Fixed by #446
Assignees
@bitfl0wer
Labels
Type: Bug

Comments

@kozabrada123
Copy link
Member

kozabrada123 commented Oct 15, 2023 •
edited
Loading

Chorus' Voice State object includes an id: Snowflake field (to derive Updateable), which only exists on Spacebar (VoiceState class on SB, BaseClass on SB vs VoiceState object on DDC and VoiceState object on Userdoccers)

This causes all Voice State Update events to fail to deserialize on DDC:

... Received message {"t":"VOICE_STATE_UPDATE","s":5,"op":0,"d":{"user_id":"1234567890","suppress":false,"session_id":"s3cr37s35510n1d","self_video":false,"self_mute":false,"self_deaf":false,"request_to_speak_timestamp":null,"mute":false,"guild_id":null,"deaf":false,"channel_id":"1234567890"}}
... Gateway: Received VOICE_STATE_UPDATE
... Failed to parse gateway event VOICE_STATE_UPDATE (missing field `id` at line 1 column 262)

A solution could be to generate a custom snowflake id when it is not given somehow from the other given ids
kozabrada123 added a commit that referenced this issue Oct 15, 2023
@kozabrada123
Clarify FIXME related to #430
feb8d46
@bitfl0wer bitfl0wer self-assigned this Nov 14, 2023
@bitfl0wer bitfl0wer mentioned this issue Nov 14, 2023
Merged
bitfl0wer added a commit that referenced this issue Nov 14, 2023
@bitfl0wer
Fix: #430 (#440)
5ca56d5 
Fixes #430
@kozabrada123
Copy link
Member Author

Closed by #440

kozabrada123 added a commit that referenced this issue Nov 16, 2023
@kozabrada123
Merge dev for #430 fix
355d3c4
@bitfl0wer bitfl0wer mentioned this issue Nov 22, 2023
Merged
bitfl0wer added a commit that referenced this issue Nov 22, 2023
@bitfl0wer
wasm support, bugfixes (#446)
a2e1567 
This PR fixes #430 and enables full support for the
`wasm32-unknown-unknown` compilation target, making chorus the first(?)
Rust Discord-API implementation to support this target.
kozabrada123 added a commit that referenced this issue Apr 16, 2024
@kozabrada123 @bitfl0wer
Primitive voice implementation (feature/voice) (#457)
56b2381 
* Add Webrtc Identify & Ready

* Add more webrtc typings

* Attempt an untested voice gateway implementation

* fmt

* Merge with main

* Same allow as for voice as normal gateway

* Test error observer

* Minor updates

* More derives

* Even more derives

* Small types update

* e

* Minor doc fixes

* Modernise voice gateway

* Add default impl for voicegatewayerror

* Make voice event fields pub

* Event updates via the scientific method

* ??

* Fix bad request in voice gateway init

* Voice gateway updates

* Fix error failing to 'deserialize' properly

* Update voice identify

* Clarify FIXME related to #430

* Update to v7

* Create seperate voice_gateway.rs and voice_udp.rs

* Restructure voice to new module

* fix: deserialization error in speaking bitflags

* feat: kinda janky ip discovery impl

* feat: return ip discovery data + minor update

* feat: packet parsing!

* fix: voice works again

* feat: add voice_media_sink_wants

(comitting uncommited changes to merge)

* chore: rename events/webrtc to events/voice_gateway

* Add UdpHandle

* chore: clippy + other misc updates

* fix: attempt to fix failing wasm build

* chore: yes clippy, that is indeed an unneeded return statement

* feat: add VoiceData struct

* feat: add VoiceData reference to UdpHandler

* feat: decryption?

* chore: formatting

* feat: add ssrc definition (op 12)

* feat: add untested sending & asbtract nonce generation

* feat: Public api! (sorta)

* small updates

* feat: add sequence number

* chore: yes

* feat: merge VoiceHandler into official development

* chore: yes clippy, you are special

* fix: duplicated gateway events

* feat: first try at vgw wasm compat

* fix: blunder

* fix: gateway connect using wrong url

* fix: properly using encrypted data, bad practice for buffer creation

* chore: split voice udp

* feat: udp error handling, create udp/backends

* fix: its the same

* chore: clarify UDP on WASM

* api: split voice gateway and udp features, test for voice gateway in WASM

* feat: new encryption modes, minor code quality

* docs: document voice encryption modes

* chore: unused imports

* chore: update getrandom version to match wasm version

* chore: update on packet size FIXME

* drop buf asap

* Okay can't do that actually

* tests: add nonce test

* normal tests work?

* docs: fix doc warning, fix incorrect refrences to 'webrtc'

* chore: json isn't a doc test

* tests: better gateway auth test

* testing tests

* update voice heartbeat, fix the new test issue

* committed too much

* fix: unused import

* fix: use ip discovery address as string, not as Vec<u8>

* chore: less obnoxious logging

* chore: better unimplemented voice modes handling

* chore: remove unused variable

* chore: use matches macro

* add voice examples, make gateway ones clearer

* rename voice example

* chore: remove unused VoiceHandler

* fix: implement gateway Reconnect and InvalidSession

* Typo

Co-authored-by: Flori <[email protected]>

* Fix a bunch of typos

Co-authored-by: Flori <[email protected]>

* fix: error handling while loading native certs

* fix: guh

* use be for nonce bytes

* fix: refactor gw and vgw closures

* remove outdated docs

---------

Co-authored-by: Flori <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bitfl0wer bitfl0wer

Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

wasm support, bugfixes polyphony-chat/chorus
2 participants
@bitfl0wer @kozabrada123