Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative route for guild deletion #513

Open
bitfl0wer opened this issue Jun 27, 2024 · 2 comments
Open

Alternative route for guild deletion #513

bitfl0wer opened this issue Jun 27, 2024 · 2 comments

Comments

@bitfl0wer
Copy link
Member

bitfl0wer commented Jun 27, 2024

I have just been made aware of the fact that Spacebars API, which I seem to have based this methods' implementation on, wrongly implemented guild deletion. Apparently, it has been DELETE /guilds/<guild_id> for years, not POST /guilds/<guild_id>/delete, as Spacebar and Chorus have implemented it.

Changing this should be an easy fix - 5 minutes tops. Note, that the Guild deletion test will fail, as the tests are based on the Spacebar server, which is wrongly implemented apparently.

https://github.com/polyphony-chat/chorus/blob/main/src/api/guilds/guilds.rs#L108-L116

@bitfl0wer
Copy link
Member Author

The current route isn't wrong. Apparently, Discord supports both routes. v9 Documentation lists the DELETE route, however. Unsure if the change is still required

@bitfl0wer bitfl0wer changed the title Wrong route for guild deletion Alternative route for guild deletion Jun 28, 2024
@Quat3rnion
Copy link
Contributor

Well, if discord supports both, then I'll add support for both on symfonia as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants